Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VERMAS (VGM) #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

VERMAS (VGM) #1

wants to merge 4 commits into from

Conversation

cmsdroff
Copy link

Hi @nissimsan

Thanks for time earlier, as promised a PR to include the VERMAS or VGM format, some questions for review !

  • VERMAS is the EDIFACT Message Name, VGM is what its called in trade, thoughts on preference for the diagram etc.
  • I know that I need to select specific reference types there are only about 3 relevant to this message format, not sure yet how to do that in the StarUML tool
  • When I generate the specs a lot of what I have selected and is shown in diagram i.e. TransportEquipment, doesn't seem to make it to the JSON or YML outputs, I know this is my learning curve in StarUML but welcome some assistance to resolve
  • I added a messageId, these are used in the EDIFACT messages for API use maybe not that relevant HOWEVER, I'm thinking the sender could be a software platform and needs to link the confirmation back up using this id too?
  • I sent you on slack a sample VERMAS to review, I would suggest we anonymise and include a sample file for people to look at, happy to contribute once this point is working

I've approached from a perspective/use case of sending to the port or terminal, if being sent via a software platform or other there maybe other fields that make it in their message guides and in some cases a deviation from the SMDG published standard under UN/CEFACT, so trying not to be influenced by this currently as I know why they are there and they are not really needed.

Look forward to your thoughts, please comment and I'll review and revise before doing another PR.

Much appreciated!

First attempt for VERMS (VGM) model, some points not right but for discussion in a PR
@cmsdroff
Copy link
Author

@nissimsan I have corrected some relationships and more of the model is generated in JSON schema, however not convinced its right, I cross checked the SI and feel its similar some key things missing from the schema to be useful once generated.

@nissimsan
Copy link
Owner

@cmsdroff, I (finally!) got around to look at your PR. The changes look perfect from a commit perspective. But unfortunately I'm not able to open the .mdj file in StarUML. Could you please try to see if the file (still) works on your machine?
If you could please also try to do a pull and see what happens? This might be due to, say, a StarUML software update.
Really wanna get this working... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants